workload: Ignore transaction restart errors. #75244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
approved these changes
Jan 20, 2022
| // data may contain error with "restart transaction" -- skip those as well. | ||
| if data != nil { | ||
| ev := data["err"] | ||
| if err, ok := ev.(error); ok && strings.Contains(err.Error(), "restart transaction") { |
There was a problem hiding this comment.
if you'd like, the check could be done once after formatting the message we log
i.e. check the resulting string from fmt.Sprintf("pgx logger [%s]: %s logParams=%v", level.String(), msg, data)
There was a problem hiding this comment.
That makes sense, I suppose; but this way it's more explicit... I'll keep it as is for now; but maybe we'll have to do this trick in the future.
|
bors r+ |
|
Canceled. |
|
Bors r+ |
|
Build failed: |
|
Bors r+ |
|
Build failed: |
|
bors r+ |
|
Build failed: |
Update pgx helpers to ignore "restart transactions" errors. Previsouly, these were sent via a "msg" portion of the Log call. It appears that these messages may also arrive in the "data". Release Notes: None
|
bors+ |
|
bors r+ |
|
Build failed (retrying...): |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pgx helpers to ignore "restart transactions" errors.
Previsouly, these were sent via a "msg" portion of the Log call.
It appears that these messages may also arrive in the "data".
Release Notes: None