Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: deflake TestTelemetry #75210

Merged
merged 1 commit into from
Jan 20, 2022
Merged

sql: deflake TestTelemetry #75210

merged 1 commit into from
Jan 20, 2022

Conversation

rytaft
Copy link
Collaborator

@rytaft rytaft commented Jan 20, 2022 •
edited
Loading

This commit deflakes TestTelemetry by adding a more precise
feature-allowlist.

Fixes #75190

Release note: None

@rytaft rytaft requested review from irfansharif, RaduBerinde and a team January 20, 2022 14:11
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rytaft
sql: deflake TestTelemetry
4af0f77 
This commit deflakes TestTelemetry by adding a more precise
feature-allowlist.

Fixes cockroachdb#75190

Release note: None
@rytaft rytaft force-pushed the deflake-telemetry branch from 1e6763d to 4af0f77 Compare January 20, 2022 14:12
irfansharif
irfansharif approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶🔬

@rytaft
Copy link
Collaborator Author

rytaft commented Jan 20, 2022

TFTR! :)

bors r+

@rytaft rytaft mentioned this pull request Jan 20, 2022
Closed
@craig
Copy link
Contributor

craig bot commented Jan 20, 2022

Build succeeded:

@craig craig bot merged commit 96779a6 into cockroachdb:master Jan 20, 2022
@irfansharif irfansharif mentioned this pull request Jan 28, 2022
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfansharif irfansharif irfansharif approved these changes

@RaduBerinde RaduBerinde Awaiting requested review from RaduBerinde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: TestTelemetry failed
3 participants
@rytaft @cockroach-teamcity @irfansharif