Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: call AllocateIDs after adding index mutations #75207

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

stevendanna
Copy link
Collaborator

While we expect that all of the index mutations added here to have
fully populated IDs and columns. Changes to the AddIndexMutation API
will soon require that AllocateIDs is called after any add index
mutation.

Release note: None

While we expect that all of the index mutations added here to have
fully populated IDs and columns. Changes to the AddIndexMutation API
will soon require that AllocateIDs is called after any add index
mutation.

Release note: None
@stevendanna stevendanna requested review from a team, shermanCRL and adityamaru and removed request for a team January 20, 2022 13:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna stevendanna removed the request for review from shermanCRL January 20, 2022 13:58
@stevendanna
Copy link
Collaborator Author

Pulled this out of a larger branch to highlight it for review in case there is some reason I'm not seeing that we weren't calling AllocateIDs here.

@adityamaru
Copy link
Contributor

I'm not super paged in to all the changes happening in AddIndexMutation but this diff seems fine on its own. I read through AllocateIDs and its comment seems to suggest it'll only allocate IDs for column, family, or index which has an ID of 0. Which seems like the right thing to regardless?

@stevendanna
Copy link
Collaborator Author

I agree that this seems like the right thing to do regardless and it should be safe.

bors r=adityamaru

@craig
Copy link
Contributor

craig bot commented Jan 21, 2022

Build succeeded:

@craig craig bot merged commit 61fa0d5 into cockroachdb:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants