Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: execgen: add overloads for INTERVAL / INT4 and INTERVAL / INT2 #75091

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

mgartner
Copy link
Collaborator

Backport 1/1 commits from #74882.

/cc @cockroachdb/release


Vectorized overloads for INTERVAL / INT4 and INTERVAL / INT2
expressions have been added. The omission of these overloads caused
errors only in rare cases because usually these expressions are retyped
to INTERVAL / INT8 by the optimizer
here.

Fixes #70738

Release note (bug fix): A bug has been fixed which caused errors in rare
cases when trying to divide INTERVAL values by INT4 or INT2
values.


Release justification: This fixes a rare panic in the vectorized execution engine when dividing INTERVALs by INT2s or INT4s.

@mgartner mgartner requested review from yuzefovich and a team January 18, 2022 18:44
@blathers-crl
Copy link

blathers-crl bot commented Jan 18, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

Vectorized overloads for `INTERVAL / INT4` and `INTERVAL / INT2`
expressions have been added. The omission of these overloads caused
errors only in rare cases because usually these expressions are retyped
to `INTERVAL / INT8` by the optimizer
[here](https://github.com/cockroachdb/cockroach/blob/583efd3cd9c7198bac935bb81a7a598e5849a269/pkg/sql/opt/optbuilder/scalar.go#L218).

Fixes cockroachdb#70738

Release note (bug fix): A bug has been fixed which caused errors in rare
cases when trying to divide `INTERVAL` values by `INT4` or `INT2`
values.
@mgartner mgartner merged commit e4e3713 into cockroachdb:release-21.1 Jan 19, 2022
@mgartner mgartner deleted the backport21.1-74882 branch January 19, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants