Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: release-21.2: backupccl,jobs: handle panics from invalid cron parsing #74893

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

adityamaru
Copy link
Contributor

Backport 1/1 commits from #74880.

/cc @cockroachdb/release


This change changes all calls to func (expr *Expression) Next
in the gorhill/cronexpr package to use a utility method instead,
that handles panics that might be thrown by the underlying library.

Fixes: #74873

Release justification (bug fix): certain invalid cron expr could
result in a panic from the undelying cronexpr parsing libarary
causing the node to crash

@adityamaru adityamaru requested review from dt and a team January 15, 2022 19:24
@blathers-crl
Copy link

blathers-crl bot commented Jan 15, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@adityamaru adityamaru removed the request for review from a team January 15, 2022 19:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This change changes all calls to `func (expr *Expression) Next`
in the `gorhill/cronexpr` package to use a utility method instead,
that handles panics that might be thrown by the underlying library.

Fixes: cockroachdb#74873

Release justification (bug fix): certain invalid cron expr could
result in a panic from the undelying cronexpr parsing libarary
causing the node to crash
@adityamaru adityamaru merged commit ae1a3e5 into cockroachdb:release-21.1 Jan 18, 2022
@adityamaru adityamaru deleted the backport21.1-74880 branch January 18, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants