release-21.1: release-21.2: backupccl,jobs: handle panics from invalid cron parsing #74893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #74880.
/cc @cockroachdb/release
This change changes all calls to
func (expr *Expression) Next
in the
gorhill/cronexpr
package to use a utility method instead,that handles panics that might be thrown by the underlying library.
Fixes: #74873
Release justification (bug fix): certain invalid cron expr could
result in a panic from the undelying cronexpr parsing libarary
causing the node to crash