streamingccl/streampb: ensure there's at least one go source file #74888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the directory is empty (prior to deriving .pb.go from .proto), the go compiler has no package name for that directory. This prevents the execution of `go mod tidy` and `make vendor_rebuild`, and even prevents the generation of the `.pb.go` file, resulting in a catch-22. Release note: None
|
This change is |
|
I'm going to merge this today, as it's blocking other dependency cleanup work. If you'd like to address this in another way, we can do a followup PR. bors r+ |
|
Build succeeded: |
|
Lgtm. Thanks
…On Sat, Jan 15, 2022, 9:28 AM craig[bot] ***@***.***> wrote:
Merged #74888 <#74888> into
master.
—
Reply to this email directly, view it on GitHub
<#74888 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANA4FVEP44JSQXG333M2RSLUWGACTANCNFSM5MA6ADOQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74887
When the directory is empty (prior to deriving .pb.go from .proto),
the go compiler has no package name for that directory.
This prevents the execution of
go mod tidyandmake vendor_rebuild, and even prevents the generation of the.pb.gofile, resulting in a catch-22.
Release note: None