jobs,backup,vendor: switch from gorhill/cronexpr to robfig/cron #74881
Conversation
|
This change is |
dt
force-pushed
the
cron
branch
2 times, most recently
from
d10239f to
b7b6696
Compare
|
Updated release note to identify this as a backward-incompatible change, since it eliminates support for two non-standard expression forms (those with 6 or 7 field, to specify seconds and years). |
Hmm, think we should have a fallback to the old path for existing cron jobs that may be using those expressions? Seems like this could be a surprise after upgrade. |
|
I checked our docs on schedule expressions and they just link to Wikipedia for what's supported. The formats the article describes as standard are supported by both the old and new libraries; Seconds and specific years were never standard. So I don't think we're regressing in documented functionality but I just wanted to call out the change explicitly all the same. Either way I'm not sure that the change confined to those undocumented and non-standard expressions is enough to keep using a library that is abandoned, unmaintained and has severe bugs. |
|
OK, let’s make sure it ends up under “breaking changes” in release notes nonetheless. We’ve had issues in the past which were correctness improvements, but also breaking changes, and ended up blocking a customer upgrade. |
gorhill/cronexpr is abandoned, and we recently found a known panic that was crashing nodes that upstream considered known behavior when an invalid expression was provided. While robfig/cron is a full scheduled job execution framework, we can use its parser separately as well, which is what this change does. Release note (bug fix): Certain malformed backup schedule expressions no longer cause the node to crash. Release note (backward-incompatible change): Non-standard cron expressions that specify seconds or year fields are no longer supported.
Yep, that's what the TFTRs! bors r+ |
|
Build succeeded: |
|
Thank you @robfig. |
gorhill/cronexpr is abandoned, and we recently found a known panic that was
crashing nodes that upstream considered known behavior when an invalid expression
was provided. While robfig/cron is a full scheduled job execution framework, we can
use its parser separately as well, which is what this change does. When presented with
the same malformed expression as before, CREATE SCHEDULE now returns an error.
Release note (bug fix): certain malformed backup schedule expressions no longer cause the node to crash