sql: support setting check_function_bodies
#74828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commonly appears in dumps as noise for the actual problem (CREATE FUNCTION doesn't work). This commit adds setting the variable, but we don't do anything with it because we don't support UDFs. Release note (sql change): Support setting `check_function_bodies`. Note this doesn't variable doesn't do anything.
|
This change is |
|
bit more controversial ... let me know what you think ... |
rafiss
approved these changes
Jan 19, 2022
rafiss
reviewed
Jan 19, 2022
|
not easily :( needs a lot more plumbing to bors r=rafiss |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commonly appears in dumps as noise for the actual problem (CREATE
FUNCTION doesn't work). This commit adds setting the variable, but we
don't do anything with it because we don't support UDFs.
Release note (sql change): Support setting
check_function_bodies. Notethis doesn't variable doesn't do anything.