sql: add assignment casts for UPSERTs #74763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Reviewed 11 of 12 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @rytaft)
pkg/sql/opt/optbuilder/mutation_builder.go, line 724 at r1 (raw file):
} // roundDecimalValues wraps each DECIMAL-related column (including arrays of
🥳
Assignment casts are now added to query plans for upserts, including `UPSERT`, `INSERT .. ON CONFLICT DO NOTHING`, and `INSERT .. ON CONFLICT DO UPDATE ..` statements. Assignment casts are a more general form of the logic for rounding decimal values, so the use of `round_decimal_values` in mutations is no longer needed. This logic has been removed. Fixes cockroachdb#67083 There is no release note because the behavior of upserts should not change with this commit. Release note: None
mgartner
force-pushed
the
assignment-cast-upsert
branch
from
7fefa78 to
e7cab43
Compare
rytaft
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Reviewed 11 of 12 files at r1, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:
Release note: None
mgartner
force-pushed
the
assignment-cast-upsert
branch
from
e7cab43 to
ec66320
Compare
|
TFTRs! bors r+ |
|
Build succeeded: |
|
pkg/sql/opt/optbuilder/mutation_builder.go, line 724 at r1 (raw file): Previously, RaduBerinde wrote…
I think @andy-kimball might be happy to see this complication now being naturally handled through assignment casts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: add assignment casts for UPSERTs
Assignment casts are now added to query plans for upserts, including
UPSERT,INSERT .. ON CONFLICT DO NOTHING, andINSERT .. ON CONFLICT DO UPDATE ..statements.Assignment casts are a more general form of the logic for rounding
decimal values, so the use of
round_decimal_valuesin mutations is nolonger needed. This logic has been removed.
Fixes #67083
There is no release note because the behavior of upserts should not
change with this commit.
Release note: None
sql: add logic tests for assignment casts of ON UPDATE expressions
Release note: None