Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove PHYSICAL scrub code #74761

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Conversation

RaduBerinde
Copy link
Member

The PHYSICAL scrub code is experimental and not considered production
ready. It complicates a lot of code paths involved in normal query
execution (it significantly overloads the semantics of TableReader and
of the Fetcher) and is getting in the way of some improvements in how
the fetchers work. In particular, we are trying to reduce the amount
of information passed to TableReader/Fetcher (which in the
non-scrubbing case should be a lot less than the full table
descriptor).

There are some proposals for a better design floating around, e.g.
provide a facility for returning KVs as results from DistSQL and have
some higher-level code run the scrub checks.

This change removes the code for the PHYSICAL scrub for now.

Release note (sql change): the experimental SCRUB PHYSICAL is no
longer implemented.

@RaduBerinde RaduBerinde requested review from a team as code owners January 12, 2022 20:13
@RaduBerinde RaduBerinde requested review from shermanCRL and removed request for a team January 12, 2022 20:13
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Although I was never familiar with this SCRUB code or whether it provided value for testing correctness. Might be worth getting another set of eyes too.

Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @shermanCRL)

The PHYSICAL scrub code is experimental and not considered production
ready. It complicates a lot of code paths involved in normal query
execution (it significantly overloads the semantics of TableReader and
of the Fetcher) and is getting in the way of some improvements in how
the fetchers work. In particular, we are trying to reduce the amount
of information passed to TableReader/Fetcher (which in the
non-scrubbing case should be a lot less than the full table
descriptor).

There are some proposals for a better design floating around, e.g.
provide a facility for returning KVs as results from DistSQL and have
some higher-level code run the scrub checks.

This change removes the code for the PHYSICAL scrub for now.

Release note (sql change): the experimental SCRUB PHYSICAL is no
longer implemented.
@yuzefovich
Copy link
Member

I think I brought up the idea of removing this some time ago, and @jordanlewis was a bit opposed to it. At the time I didn't have any justification other than "it's not being used", but if this code is in the way of pushing more logic into the KV pods, then I'd guess the balance has shifted. It'd be good to get an ack from Jordan though.

@RaduBerinde
Copy link
Member Author

@jordanlewis
Copy link
Member

I have no objection, I can't remember why I was opposed but now seems like a great time to do it.

@RaduBerinde
Copy link
Member Author

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Jan 13, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jan 14, 2022

Build succeeded:

@craig craig bot merged commit 3186eeb into cockroachdb:master Jan 14, 2022
@RaduBerinde RaduBerinde deleted the remove-scrub branch January 14, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants