sql: ignore shard column during unique constraint searching

[chengxiong-ruan]

Fixes #69192

Referencing table does not know about the shard column. So
need to ignore it when looking for a valid unique constraint.

Release note (bug fix): Foreign key referencing hash sharded
key won't fail anymore.

[cockroach-teamcity]

This change is 

[ajwerner]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @postamar)

---

pkg/sql/catalog/descpb/index.go, line 86 at r1 (raw file):

// key constraint with the provided set of referencedColumnIDs.
func (desc *IndexDescriptor) IsValidReferencedUniqueConstraint(referencedColIDs ColumnIDs) bool {
	colIDs := desc.ExplicitColumnIDsWithoutShardColumn()

why not just invoke this directly in the last part of the condition and short-circuit it most of the time. Also, why export it?

[chengxiong-ruan]

---

pkg/sql/catalog/descpb/index.go, line 86 at r1 (raw file):

Previously, ajwerner wrote…

why not just invoke this directly in the last part of the condition and short-circuit it most of the time. Also, why export it?

Just wanted to make the line of return shorter, yeah good idea to short-circuit it to save some computation.
Definitely no reason at this moment, was thinking it might be useful in some other cases. Will unexport it, may export it later if found real use cases.

[ajwerner]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @postamar)

---

pkg/sql/catalog/descpb/index.go, line 73 at r2 (raw file):

	explicitColIDs := desc.KeyColumnIDs[desc.ExplicitColumnStartIdx():]
	explicitColNames := desc.KeyColumnNames[desc.ExplicitColumnStartIdx():]
	colIDs := make([]ColumnID, 0, len(explicitColIDs))

nit: make this make(ColumnIDs, 0, len(explicitColIDs)), return ColumnIDs, and avoid the cast below?

---

pkg/sql/logictest/testdata/logic_test/hash_sharded_index, line 694 at r2 (raw file):

statement ok
CREATE TABLE parent (
id INT PRIMARY KEY USING HASH WITH BUCKET_COUNT = 8

nit: https://sqlfum.pt/ or cockroach sqlfmt your sql? It's jarring to see the newlines without the indentation.

[chengxiong-ruan]

Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @ajwerner and @postamar)

---

pkg/sql/catalog/descpb/index.go, line 73 at r2 (raw file):

Previously, ajwerner wrote…

nit: make this make(ColumnIDs, 0, len(explicitColIDs)), return ColumnIDs, and avoid the cast below?

👍 done

---

pkg/sql/logictest/testdata/logic_test/hash_sharded_index, line 694 at r2 (raw file):

Previously, ajwerner wrote…

nit: https://sqlfum.pt/ or cockroach sqlfmt your sql? It's jarring to see the newlines without the indentation.

TIL the sqlfmt! nice~

[chengxiong-ruan]

TFTR!

bors r+

[craig]

Build succeeded:

• GitHub CI (Cockroach)