Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envutil: avoid importing testing in non-test code #73905

Merged
merged 1 commit into from
Dec 16, 2021
Merged

envutil: avoid importing testing in non-test code #73905

merged 1 commit into from
Dec 16, 2021

Conversation

knz
Copy link
Contributor

@knz knz commented Dec 16, 2021

Thanks to @dt for noticing.

Release note: None

@knz knz requested review from dt and jeffswenson December 16, 2021 10:22
@cockroach-teamcity
Copy link
Member

This change is Reviewable

dt
dt approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@dt dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jeffswenson
jeffswenson approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for fixing this.

@knz
envutil: avoid importing testing in non-test code
84f351f 
Thanks to @dt for noticing.

Release note: None
@knz
Copy link
Contributor Author

knz commented Dec 16, 2021

bors r=dt,JeffSwenson

@craig
Copy link
Contributor

craig bot commented Dec 16, 2021

Build succeeded:

@craig craig bot merged commit db6851b into cockroachdb:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffswenson jeffswenson jeffswenson approved these changes

@dt dt dt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knz @cockroach-teamcity @dt @jeffswenson