-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rttanalysisccl: adjust alter primary region bench #73858
Conversation
This is flaky, and less is better anyway. Release note: None
bors r=RichardJCai |
Build succeeded: |
Still flaky yo - it wants 27. Fails in 15 runs on my machine if I put enough parallelism. Also, consider putting more words in the commit when bumping the expectations, if some investigation of the trace was done. If no investigation was done, that's also worth noting. |
But you gotta stress the whole package. |
I also got a failure in |
That seems a bit more of a sql-schema thing. (Actually, I think this issue might be too, but |
I'm thinking about giving it +/- 1 for now. It's starting to drive me nuts. We mostly care about the scaling. It's pretty unsatisfying. I did add some code to make it give me a jaeger trace in hopes of being able to spot the difference in that more clearly. |
I like this, I think most of the unexpected failures are from +/- 1. We really don't care about those failures. |
fixes #73775
This is flaky, and less is better anyway.
Release note: None