-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backupccl: add BackupMonitor to memory monitor file stitching #73805
Conversation
92b9b78
to
65c5ab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't immediately see why we need all the nil check no-ops on the accumulator but otherwise looks great
65c5ab6
to
e24a2a4
Compare
4982a6d
to
2ef6458
Compare
I do not understand the Bazel timeouts in testrace and stress:
Rebased to try and kickoff another run to see if that fixes it. |
Bazel team is aware of the linker error. Going to go ahead and bors this. TFTR! |
Build failed: |
bors r=dt |
Build failed: |
This change adds a BackupMonitor that hangs off the bulk memory monitor. This monitor currently only guards the queue that we use to buffer SSTs while stitching them together in the sstSink. Release note: None
2ef6458
to
1ac3e93
Compare
Lets try this again, bazel failure is the known linker error. bors r=dt |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 1ac3e93 to blathers/backport-release-21.2-73805: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This change adds a BackupMonitor that hangs off the bulk memory
monitor. This monitor currently only guards the queue that we use
to buffer SSTs while stitching them together in the sstSink.
Informs: #73815
Release note: None