Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingccl: use roachpb.TenantID in job proto #73793

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

dt
Copy link
Member

@dt dt commented Dec 14, 2021

Not bothering with dual write/read old and new field, since there is no
backwards compat concern for this unlaunched feature.

Release note: none.

Not bothering with dual write/read old and new field, since there is no
backwards compat concern for this unlaunched feature.

Release note: none.
@dt dt requested review from gh-casper and a team December 14, 2021 13:59
@dt dt requested a review from a team as a code owner December 14, 2021 13:59
@dt dt requested review from stevendanna and removed request for a team December 14, 2021 13:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@miretskiy miretskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gh-casper and @stevendanna)

@dt
Copy link
Member Author

dt commented Dec 14, 2021

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 14, 2021

Build succeeded:

@craig craig bot merged commit 7167b22 into cockroachdb:master Dec 14, 2021
@dt dt deleted the stream-tenant-id branch December 21, 2021 04:45
@shermanCRL shermanCRL added the A-tenant-streaming Including cluster streaming label Jul 29, 2022
@shermanCRL shermanCRL added this to the 22.1 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tenant-streaming Including cluster streaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants