kvserver: alter balanceScore result to classify stores into 3 buckets #73614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
In cockroachdb#65379 we changed `balanceScore()` to classify stores in a cluster into 4 buckets: underfull, less-than-mean, more-than-mean and overfull. This allowed for the possibility of thrashing around the mean (i.e. replicas could ping-pong between stores classified as less-than-mean and more-than-mean). This patch moves balanceScore back to its previous incarnation, which only divided resulting stores into 3 buckets. Release justification: Fixes regression introduced in a previous patch Release note: None
aayushshah15
force-pushed
the
20211208_revertBalanceScoreComputation
branch
from
4e9b52e to
e5d3d89
Compare
|
This is ready for a look. |
irfansharif
approved these changes
Dec 10, 2021
nvanbenschoten
approved these changes
Dec 16, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aayushshah15)
|
TFTR! |
|
Build failed (retrying...): |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #65379 we changed
balanceScore()to classify stores in a cluster into 4 buckets:underfull, less-than-mean, more-than-mean and overfull. This
allowed for the possibility of thrashing around the mean (i.e. replicas
could ping-pong between stores classified as less-than-mean and
more-than-mean).
This patch moves balanceScore back to its previous incarnation, which
only divided resulting stores into 3 buckets.
Release justification: Fixes regression introduced in a previous patch
Release note: None