release-21.2: sql: do not include inaccessible columns in information_schema.columns #73540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
blathers-crl
bot
force-pushed
the
blathers/backport-release-21.2-73447
branch
from
e8846a9 to
222dfd5
Compare
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
blathers-backport
|
This change is |
rafiss
approved these changes
Dec 7, 2021
rafiss
reviewed
Dec 7, 2021
| SELECT * FROM [SHOW COLUMNS FROM t] ORDER BY column_name | ||
| ---- | ||
| column_name data_type is_nullable column_default generation_expression indices is_hidden | ||
| a INT8 true NULL · {t_pkey} false |
There was a problem hiding this comment.
looks like t_pkey needs to be changed to primary for the backport
|
Reminder: it has been 3 weeks please merge or close your backport! |
This commit omits inaccessible columns from the `information_schema.columns` table. Inaccessible columns are also excluded in `SHOW COLUMNS` due to its reliance on `information_schema.columns`. Fixes #70505 Release note (bug fix): Internal columns created by the system to support expression indexes are now omitted from the output of `SHOW COLUMNS` statements and the `information_schema.columns` table.
mgartner
force-pushed
the
blathers/backport-release-21.2-73447
branch
from
222dfd5 to
e420f0f
Compare
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error getting backport branch release-pr-activity: GET https://api.github.com/repos/cockroachdb/cockroach/branches/release-pr-activity: 404 Branch not found [] Backport to branch pr-activity failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #73447 on behalf of @mgartner.
/cc @cockroachdb/release
This commit omits inaccessible columns from the
information_schema.columnstable. Inaccessible columns are alsoexcluded in
SHOW COLUMNSdue to its reliance oninformation_schema.columns.Fixes #70505
Release note (bug fix): Internal columns created by the system to
support expression indexes are now omitted from the output of
SHOW COLUMNSstatements and theinformation_schema.columnstable.Release justification: This is a minor bug fix for expression indexes, a
new feature in 21.2.