roachtest: fix flags used in multitenant-upgrade for versions >= v21.2 #73145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
AlexTalks
force-pushed
the
fix_mt_upgrade
branch
from
d26b74e to
3d8fbfd
Compare
Previously, the `multitenant-upgrade` test had several workarounds and branches for dealing with predecessor versions less than v21.2, particularly the fact that these versions did not support the `--store` flag passed on the `mt start-sql` CLI command. This was introduced in cockroachdb#71040, and subsequently incorporated into the roachtest (including workarounds) in cockroachdb#71604. Now that the current version is v22.1, and thus the predecessor version supports the `--store` flag, it is necessary to remove the workaround in order to ensure proper functionality of the test. Additionally, this change cleans up an even earlier workaround for validating the cluster version for predecessor versions less than v21.1.2. Fixes cockroachdb#72971. Release note: None
AlexTalks
force-pushed
the
fix_mt_upgrade
branch
from
3d8fbfd to
7b4a233
Compare
tbg
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
Thank you!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @AlexTalks)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
multitenant-upgradetest had several workarounds andbranches for dealing with predecessor versions less than v21.2,
particularly the fact that these versions did not support the
--storeflag passed on the
mt start-sqlCLI command. This was introducedin #71040, and subsequently incorporated into the roachtest (including
workarounds) in #71604. Now that the current version is v22.1, and thus
the predecessor version supports the
--storeflag, it is necessary toremove the workaround in order to ensure proper functionality of the
test. Additionally, this change cleans up an even earlier workaround
for validating the cluster version for predecessor versions less than
v21.1.2.
Fixes #72971.
Release note: None