kvserver: fix envvar in closed timestamp regression error hint #73020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a closed timestamp is found to regress, an assertion error is returned containing this hint: ``` This assertion will fire again on restart; to ignore run with env var COCKROACH_RAFT_CLOSEDTS_ASSERTIONS_ENABLED=true ``` However, this is incorrect: the env var must be set to `false`, not `true`, to disable the assertion. This patch fixes that, and adds a missing newline as well. Release note: None
|
This change is |
tbg
approved these changes
Nov 22, 2021
|
bors r=tbg |
|
Build succeeded: |
This was referenced Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a closed timestamp is found to regress, an assertion error is
returned containing this hint:
However, this is incorrect: the env var must be set to
false, nottrue, to disable the assertion. This patch fixes that, and adds amissing newline as well.
Resolves #72812.
Release note: None