protectedts: improve a test #72933
Merged
protectedts: improve a test #72933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was starting a Reconciler by hand, running against an existing Server. The Reconciler was using the cluster's stopper (as opposed to the server's stopper). In doing so, we ended up with two different Tracers contributing to the same traces. This is pretty broken and will become dissallowed. The patch fixes it by configuring the alien Reconciler with the same stopper (and tracer) as the server it's running against. Release note: None
|
This change is |
ajwerner
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @andreimatei)
andreimatei
commented
Nov 18, 2021
There was a problem hiding this comment.
bors r+
Reviewable status:
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was starting a Reconciler by hand, running against an existing
Server. The Reconciler was using the cluster's stopper (as opposed to
the server's stopper). In doing so, we ended up with two different Tracers
contributing to the same traces. This is pretty broken and will become
dissallowed. The patch fixes it by configuring the alien Reconciler with
the same stopper (and tracer) as the server it's running against.
Release note: None