sql: use Latest[Non]PrimaryIndexDescriptorVersion constants in more places #72818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Reviewed 23 of 23 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner and @postamar)
pkg/sql/doctor/doctor_test.go, line 56 at r1 (raw file):
Version: descpb.PrimaryIndexWithStoredColumnsVersion,
This one I could see wanting to leave as the fixed value. 🤷
mgartner
force-pushed
the
use-latest-index-version-consts
branch
2 times, most recently
from
a12a16a to
0ee2fe2
Compare
mgartner
commented
Nov 16, 2021
There was a problem hiding this comment.
Reviewable status:
pkg/sql/doctor/doctor_test.go, line 56 at r1 (raw file):
Previously, ajwerner wrote…
Version: descpb.PrimaryIndexWithStoredColumnsVersion,This one I could see wanting to leave as the fixed value. 🤷
Done.
mgartner
force-pushed
the
use-latest-index-version-consts
branch
2 times, most recently
from
2a01881 to
57f5061
Compare
|
@ajwerner mind taking another quick look? I had to move the constants to avoid a cycle. |
mgartner
force-pushed
the
use-latest-index-version-consts
branch
from
57f5061 to
0b9db6d
Compare
…laces These constants have been moved from tabledesc to descpb to avoid import cycles. Release note: None
mgartner
force-pushed
the
use-latest-index-version-consts
branch
from
0b9db6d to
08435c3
Compare
|
TFTRs! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These constants have been moved from tabledesc to descpb to avoid import
cycles.
Release note: None