Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: create error Boundary component #72770

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Conversation

maryliag
Copy link
Contributor

Previously, when there was an error on the pages on the console
it would crash and nothing would load. This commit introduces
an error boundary, making an error message show instead of the
blank page.

Screen Shot 2021-11-15 at 1 47 39 PM

Release note (ui change): New page for when something goes wrong
and the page crashes.

Previously, when there was an error on the pages on the console
it would crash and nothing would load. This commit introduces
an error boundary, making an error message show instead of the
blank page.

Release note (ui change): New page for when something goes wrong
and the page crashes.
@maryliag maryliag requested a review from a team November 15, 2021 18:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)

@maryliag
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 16, 2021

Build succeeded:

@craig craig bot merged commit cb5d510 into cockroachdb:master Nov 16, 2021
@maryliag maryliag deleted the error-boundary branch November 18, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants