Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.2: update app filter #72755

Merged
merged 3 commits into from
Nov 15, 2021
Merged

release-21.2: update app filter #72755

merged 3 commits into from
Nov 15, 2021

Conversation

maryliag
Copy link
Contributor

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: Category 4

@maryliag
ui: use $internal instead of (internal) for filter
55e6327 
Previously we were using `(internal)` and `$ internal`
to identify internal statements and transactions.
This commits aligns all usages, with all places using
`$ internal` now.

Release note (ui change): Replace `(internal)` on filter and details
on Statements page for `$ internal` to align with Transactions Page.
@maryliag
ui:app filter is has multi select option
0f13a95 
Previously you could only select one App on the filter for
Transaction and Statement page. This commits introduces a
multi select option, making possible for the user select
several apps at the same time and exclude internal results.

This commits also properly sets the filter value for database
with no values to (unset).

Partially addresses cockroachdb#70544

Not included in this commit:
- Select all apps except internal by default
- Add app filter to Session tab

Release note (ui change): App filter on Transaction and Statement
pages is now multi select.
@maryliag
ui: default filter on Transaction and Statement page exclude internals
a35e368 
Previously, the default value when no App filter was
selected on Transactions and Statements page, we were showing
all data, now we're excluding internal transaction/statements.

Fixes cockroachdb#70544

Release note (ui change): The default value when no App is selected
on Transactions and Statements filter is now excluding internal
Transactions and Statements.
@maryliag maryliag requested a review from a team November 15, 2021 15:55
@blathers-crl
Copy link

blathers-crl bot commented Nov 15, 2021 •
edited by maryliag
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

matthewtodd
matthewtodd approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@matthewtodd matthewtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@maryliag maryliag merged commit f159c95 into cockroachdb:release-21.2 Nov 15, 2021
@maryliag maryliag deleted the backport21.2-71581-71897-71966 branch November 15, 2021 20:17
This was referenced Nov 15, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azhng Azhng Azhng approved these changes

@matthewtodd matthewtodd matthewtodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maryliag @cockroach-teamcity @matthewtodd @Azhng