cmd/roachtest: fix --cluster for new roachprod
#72749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
approved these changes
Nov 15, 2021
The `roachprod list` command no longer takes a positional argument to filter the results. This commit adopts the new `--pattern` flag in `roachtest`. This is important when providing your own cluster for roachtest with the `--cluster` flag. Release note: None
ajwerner
force-pushed
the
ajwerner/filter-for-roachtest
branch
from
1f967d8 to
a79f290
Compare
Done. |
erikgrinaker
approved these changes
Nov 15, 2021
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
roachprod listcommand no longer takes a positional argument to filterthe results. This commit adopts the new
--patternflag inroachtest. Thisis important when providing your own cluster for roachtest with the
--clusterflag.
Release note: None