server: tidy tenant testing client #72692
Merged
+40
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Azhng
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @Azhng and @matthewtodd)
pkg/ccl/serverccl/statusccl/tenant_status_test.go, line 721 at r1 (raw file):
sqlPod0 := helper.testCluster().tenantConn(0) results := make(chan struct{}) errs := make(chan error)
nit: s/errs/errChan/
Pushing these assertions into the test client removes some of the line noise from the tests, making them easier to read. We also generalize the tenant http client to provide plain text as well as json responses. Release note: None
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
|
@matthewtodd do you mind If I backport this PR to 21.2 ? |
|
Go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing these assertions into the test client removes some of the line
noise from the tests, making them easier to read. We also generalize the
tenant http client to provide plain text as well as json responses.
Release note: None