jobs: follow pattern to use the background context #72651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
|
This change is |
craig bot
pushed a commit
that referenced
this pull request
Nov 11, 2021
72638: catalog/lease: avoid using context.Background directly r=ajwerner a=knz First commit from #72651 Informs #58938. - `(*AmbientContext).AnnotateCtx()` - takes care of connecting the context to the tracer - `logtags.FromContext` / `logtags.WithTags` - reproduces the logging tags on the child context. Release note: None 72640: sql/types: types.EnumMetadata implements encoding.TextMarshaler interface r=chengxiong-ruan a=chengxiong-ruan Fixes #63379 `types.EnumMetadata` needs to implement `encoding.TextMarshaler` interface so that goto/protobuf won't panic when text marshaling protobuf struct has child field of type `types.EnumMetadata`. See the issue for more details why it would fail without this fix. Release note: None 72644: server: improve the tenant context r=RaduBerinde a=knz All commits but the last from #72638 (Reviewers: only review last commit) Informs #58938 72647: admission,server: context improvements r=RaduBerinde a=knz All commits but the last 2 from #72644 (Reviewers: only review last 2 commits) Informs #58938 72650: streamingest: wait for all goroutines on streamIngestProcessor shutdown r=andreimatei a=andreimatei This processor was failing to stop and wait for some of the goroutines it spawned, which is not nice (in particular, it's likely that those goroutines were using a tracing span after it was finished). Release note: None 72652: internal/sqlsmith: do not use crdb_internal.start_replication_stream r=yuzefovich a=yuzefovich Fixes: #72633. Fixes: #72634. Release note: None 72661: migration: add missing leaktests r=andreimatei a=andreimatei Release note: None 72668: roachtest: add assignment-cast related failures to pgjdbc r=RichardJCai a=rafiss fixes #72636 Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Andrei Matei <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #72605.
Informs #58938.
(*AmbientContext).AnnotateCtx()- takes care of connecting thecontext to the tracer
logtags.FromContext/logtags.WithTags- reproduces the loggingtags on the child context.
Release note: None