logictest: enable more tenant tests #72566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
force-pushed
the
ssd/tenacious
branch
2 times, most recently
from
a174252 to
9cfc60a
Compare
RaduBerinde
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Make sure to run these tests under make stress for a while to make sure they're not flaky under this config.
Reviewable status:
complete! 1 of 0 LGTMs obtained
I ran it for a few hours (which was only ~500 iterations because of the time of the tests) and having seen a problem yet. |
stevendanna
force-pushed
the
ssd/tenacious
branch
from
9cfc60a to
7fdc240
Compare
This PR removes the 3node-tenant exclusion for test suites that worked without modification locally. Further, in the case of the enums and builtin_function suites, it moves a few tests into a different file so that the rest of the tests can be run in tenant mode. This was the result of an initial pass through all the test files marked !3node-tenant. There are likely more tests we can enable. Release note: None
stevendanna
force-pushed
the
ssd/tenacious
branch
from
7fdc240 to
71118ee
Compare
|
bors r=RaduBerinde |
|
Build failed (retrying...): |
|
Build failed: |
|
bors retry |
|
Build failed (retrying...): |
|
Build succeeded: |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the 3node-tenant exclusion for test suites that worked
without modification locally.
Further, in the case of the enums and builtin_function suites, it
moves a few tests into a different file so that the rest of the tests
can be run in tenant mode.
This was the result of an initial pass through all the test files
marked !3node-tenant. There are likely more tests we can enable.
Release note: None