ccl: refactor tenant status server test to statusccl package

[Azhng]

Previously, tenant status server tests live within serverccl package.
However, this caused all nightly test failures to automaticallly
notify server team through GitHub code owner file.
This commit moves all tenant status server into statusccl package
and update statusccl package code owner to SQL O11y.

Release note: None

[cockroach-teamcity]

This change is 

[lindseyjin]

Reviewed 2 of 8 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @knz)

---

pkg/ccl/serverccl/statusccl/main_test.go, line 15 at r1 (raw file):

	"testing"

	_ "github.com/cockroachdb/cockroach/pkg/ccl"

Btw, is there supposed to be an underscore here? What does that mean?

[Azhng]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @knz)

---

pkg/ccl/serverccl/statusccl/main_test.go, line 15 at r1 (raw file):

is there supposed to be an underscore here

Yes.

What does that mean?

When importing a package, all the symbols within the package will be available under the package name, e.g.

import "github.com/cockroachdb/cockroach/pkg/security"

//...  later in the same file

security.ExportedSymbols // <- exported symbols are available under the `security` package name

However, in golang, there is a special function called init, which is defined as :

package some_package_name

func init() {
   // does stuff 
}

This function is not exported since it's lowercase. However, if this package is being imported by some other package, then the init function will be executed upon startup. This is done in ccl package to inject ccl functionalities into the CRDB

[lindseyjin]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @knz)

---

pkg/ccl/serverccl/statusccl/main_test.go, line 15 at r1 (raw file):

Previously, Azhng (Archer Zhang) wrote…

is there supposed to be an underscore here

Yes.

What does that mean?

When importing a package, all the symbols within the package will be available under the package name, e.g.

import "github.com/cockroachdb/cockroach/pkg/security"

//...  later in the same file

security.ExportedSymbols // <- exported symbols are available under the `security` package name

However, in golang, there is a special function called init, which is defined as :

package some_package_name

func init() {
   // does stuff 
}

This function is not exported since it's lowercase. However, if this package is being imported by some other package, then the init function will be executed upon startup. This is done in ccl package to inject ccl functionalities into the CRDB

Ah, I see, so we're importing the package just to execute the init function?

[Azhng]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @knz)

---

pkg/ccl/serverccl/statusccl/main_test.go, line 15 at r1 (raw file):

Previously, lindseyjin (Lindsey Jin) wrote…

Ah, I see, so we're importing the package just to execute the init function?

for pkg/ccl here yes 👍

[maryliag]

just one small nit and

Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @Azhng and @knz)

---

pkg/ccl/serverccl/statusccl/main_test.go, line 34 at r2 (raw file):

}

//go:generate ../../../util/leaktest/add-leaktest.sh *_test.go

nit: did you forget to remove this comment?

[Azhng]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @knz and @maryliag)

---

pkg/ccl/serverccl/statusccl/main_test.go, line 34 at r2 (raw file):

Previously, maryliag (Marylia Gutierrez) wrote…

nit: did you forget to remove this comment?

I think this comment was originally explicitly left to to ensure leak test are injected into all unit tests.

[Azhng]

TFTR!

bors r=maryliag

[craig]

Build succeeded:

• GitHub CI (Cockroach)