Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionphase: fix service latency computation in an error case #72493

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

yuzefovich
Copy link
Member

If we encounter an error during the logical planning, then the end
execution phase is never set. Previously, we would use that unset value
in order to compute the latency of planning and execution and would get
a negative result. This is now fixed.

Release note: None

@yuzefovich yuzefovich requested review from Azhng and a team November 5, 2021 22:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

If we encounter an error during the logical planning, then the end
execution phase is never set. Previously, we would use that unset value
in order to compute the latency of planning and execution and would get
a negative result. This is now fixed.

Release note: None
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @Azhng)

@yuzefovich
Copy link
Member Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 8, 2021

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Nov 8, 2021

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Nov 8, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 2257e81 to blathers/backport-release-21.1-72493: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants