Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.2: sql: fix excess privileges being created from default privileges. #72410

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 3, 2021

Backport 1/1 commits from #72323 on behalf of @RichardJCai.

/cc @cockroachdb/release


Release note (bug fix): Previously, when creating an object
default privileges from users that were not the user creating
the object would be added to the privileges of the object.
This fix ensures only the relevant default privileges are applied.

Resolves #72322


Release justification:

Release note (bug fix): Previously, when creating an object
default privileges from users that were not the user creating
the object would be added to the privileges of the object.
This fix ensures only the relevant default privileges are applied.
@blathers-crl blathers-crl bot requested a review from a team November 3, 2021 21:00
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-21.2-72323 branch from c186df0 to 7859cd1 Compare November 3, 2021 21:00
@blathers-crl
Copy link
Author

blathers-crl bot commented Nov 3, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss
Copy link
Collaborator

rafiss commented Nov 3, 2021

let's wait until 21.2.0 is released

@RichardJCai
Copy link
Contributor

let's wait until 21.2.0 is released

Wait, I'm a bit lost on this. Do we not want this fix to go into 21.2.0?

@RichardJCai
Copy link
Contributor

@rafiss This can be merged now right?

@rafiss
Copy link
Collaborator

rafiss commented Nov 15, 2021

@RichardJCai yes, now is good!

@RichardJCai RichardJCai merged commit 4e11601 into release-21.2 Nov 15, 2021
@RichardJCai RichardJCai deleted the blathers/backport-release-21.2-72323 branch November 15, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants