build: fix bazel invocation of stress in github-pull-request-make #72379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every run of the stress and stressrace bazel CI jobs were failing
with:
[17:16:00][Run stress tests] /bin/bash: stress: command not found
I haven't dug into the Git history enough to know why this was working
before. Rather, I've just copied what the `dev` tool does for me and
checked that the constructed `bazci` command does in fact work.
Release note: None
|
This change is |
This adds the ability to feed in package and test names via an environment variable rather than depending on GitHub. It also allows one to force a bazel build. I found this helpful when debugging a problem with this command. Release note: None
stevendanna
force-pushed
the
ssd/maybe-stress
branch
from
69f4fed to
1940285
Compare
stevendanna
commented
Nov 3, 2021
| @@ -254,13 +303,13 @@ func main() { | |||
| args = append(args, "--test_arg=-test.timeout", fmt.Sprintf("--test_arg=%s", timeout)) | |||
| // Give the entire test 1 more minute than the duration to wrap up. | |||
| args = append(args, fmt.Sprintf("--test_timeout=%d", int((duration+1*time.Minute).Seconds()))) | |||
| // NB: stress and bazci are expected to be put in `PATH` by the caller. | |||
| args = append(args, "--run_under", fmt.Sprintf("stress -stderr -maxfails 1 -maxtime %s -p %d", duration, parallelism)) | |||
| args = append(args, "--run_under", fmt.Sprintf("%s -stderr -maxfails 1 -maxtime %s -p %d", bazelStressTarget, duration, parallelism)) | |||
There was a problem hiding this comment.
For reviewers, this is the important bit.
|
no problemo, thanks for the review! The CI failures are all unrelated. bors r=rickystewart |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every run of the stress and stressrace bazel CI jobs were failing
with:
I haven't dug into the Git history enough to know why this was working
before. Rather, I've just copied what the
devtool does for me andchecked that the constructed
bazcicommand does in fact work.Fixes #72321