Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix comment on constraint for tables in a schema #71985

Merged

Conversation

RichardJCai
Copy link
Contributor

Release note (sql change): Previously if you did comment on constraint
on a table in a schema the command would succeed but the comment
would not actually created. Now the comment is successfully created.

Release note (sql change): Previously if you did comment on constraint
on a table in a schema the command would succeed but the comment
would not actually created. Now the comment is successfully created.
@RichardJCai RichardJCai requested review from e-mbrown and a team October 26, 2021 14:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@e-mbrown e-mbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @RichardJCai)

@RichardJCai
Copy link
Contributor Author

TFTR!
bors r=e-mbrown

@craig
Copy link
Contributor

craig bot commented Oct 27, 2021

Build failed:

@RichardJCai
Copy link
Contributor Author

bors r=e-mbrown

@craig
Copy link
Contributor

craig bot commented Nov 3, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants