Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/tracing: remove handling for impossible error #71942

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

andreimatei
Copy link
Contributor

InjectMetaInto can no longer return an error (and I don't forsee it ever
returning an error again), so this patch cleans up the unused retval.

Release note: None

@andreimatei andreimatei requested a review from a team as a code owner October 25, 2021 16:50
@cockroach-teamcity
Copy link
Member

This change is Reviewable

InjectMetaInto can no longer return an error (and I don't forsee it ever
returning an error again), so this patch cleans up the unused retval.

Release note: None
@andreimatei andreimatei force-pushed the tracing.small.inject-error branch from d3c5b5c to 9d85ef3 Compare October 25, 2021 21:34
Copy link
Contributor

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, :lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Copy link
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

bors r+

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@craig
Copy link
Contributor

craig bot commented Oct 28, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 28, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 28, 2021

Build succeeded:

@craig craig bot merged commit 90881be into cockroachdb:master Oct 28, 2021
@andreimatei andreimatei deleted the tracing.small.inject-error branch January 22, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants