opt: make index names in test catalog consistent with real catalog #71818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
michae2
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Reviewed 33 of 33 files at r1, 50 of 53 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2, @otan, and @rytaft)
otan
approved these changes
Oct 21, 2021
This commit updates the test catalog to name primary keys in the form `<table_name>_pkey`. This makes primary index names consistent with the real catalog and Postgres. See cockroachdb#70604. Release note: None
…catalog This commit updates the test catalog to name secondary keys consistently with the real catalog and Postgres. Release note: None
mgartner
force-pushed
the
testcat-index-naming
branch
from
594c241 to
8a9e560
Compare
|
TFTRs! bors r+ |
|
Build succeeded: |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opt: name primary indexes <table_name>_pkey in test catalog
This commit updates the test catalog to name primary keys in the form
<table_name>_pkey. This makes primary index names consistent with thereal catalog and Postgres. See #70604.
Release note: None
opt: make secondary index names in test catalog consistent with real catalog
This commit updates the test catalog to name secondary keys consistently
with the real catalog and Postgres.
Release note: None