sqlbase: allow FamilyFormatVersion in tabledesc validate

[danhhz]

The beta containing this commit will start the range of versions that are
bidirectionally compatible with the full implementation of column families
(module tables that use the feature). Every commit before this will be
forward-only compatible.

---

This change is

[dt]

I kinda want to iterate over al desc's at startup to get their error earlier? or the global version file (that exists, right)?

Previously, paperstreet (Daniel Harrison) wrote…

sqlbase: allow FamilyFormatVersion in tabledesc validate

The beta containing this commit will start the range of versions that are

bidirectionally compatible with the full implementation of column families

(module tables that use the feature). Every commit before this will be

forward-only compatible.

---

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

sql/sqlbase/structured.go, line 543 [r1] (raw file):

  // tests with it as the new bidirectional compatibility version. Then remove
  // support here for BaseFormatVersion.
  if desc.GetFormatVersion() != BaseFormatVersion && desc.GetFormatVersion() != FamilyFormatVersion {

if v := desc.GetFormatVersion(); v != ...

---

Comments from Reviewable

[danhhz]

#7136

Previously, dt (David Taylor) wrote…

I kinda want to iterate over al desc's at startup to get their error earlier? or the global version file (that exists, right)?

---

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

---

sql/sqlbase/structured.go, line 543 [r1] (raw file):

Previously, dt (David Taylor) wrote…

if v := desc.GetFormatVersion(); v != ...

Done.

---

Comments from Reviewable

[dt]

Previously, paperstreet (Daniel Harrison) wrote…

#7136

---

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks pending.

---

Comments from Reviewable

[dt]

@jseldess this isn't a breaking change, but will be the oldest-compatible-version when the upcoming breaking change happens

[jseldess]

Thanks for the callout, @dt.