security: remove the node TLS client cert exemption #71134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
this doesn't work, as explained here #71102 (comment) |
|
@andy-kimball can you also check the sql proxy test changes here thanks |
chrisseto
reviewed
Oct 5, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andy-kimball, @bdarnell, @catj-cockroach, and @knz)
pkg/ccl/sqlproxyccl/proxy_handler_test.go, line 1041 at r1 (raw file):
te.setAuthenticated(false) te.setErrToClient(nil) t.Logf("WOO %q", url)
nit: Remove this log line or make it more informative if it should stay.
catj-cockroach
approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:
knz
force-pushed
the
20211005-tls
branch
4 times, most recently
from
ed821ba to
608c15b
Compare
knz
commented
Oct 5, 2021
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/sqlproxyccl/proxy_handler_test.go, line 1041 at r1 (raw file):
Previously, chrisseto (Chris Seto) wrote…
nit: Remove this log line or make it more informative if it should stay.
Done
knz
force-pushed
the
20211005-tls
branch
4 times, most recently
from
d085991 to
4eca33c
Compare
|
The test changes LGTM. |
This patch also fixes the TestComposeGSSPython test. Release note (security update): It is not possible any more to use a node TLS certificate to establish a SQL connection with another username than `node`. This facility had existed as an "escape hatch" so that an operator could use the node cert to perform operations on behalf of another SQL user. However, this facility is not necessary: an operator with access to a node cert can log in as `node` directly and create new credentials for another user anyway. By removing this facility, we tighten the guarantee that the principal in the TLS client cert always matches the SQL identity.
|
ok the tests pass now I think bors r=catj-cockroach,andy-kimball |
|
Build succeeded: |
knz
added a commit
to knz/cockroach
that referenced
this pull request
May 24, 2022
The RSA key size used by TLS certs for acceptance tests must be at least 2048 to please OpenSSL (which is used by libpq in tests). The previous PR cockroachdb#71134 had improved this for some cases but the chance was hidden in-between other things. This commit makes it clearer what is going on. Release note: None
knz
added a commit
to knz/cockroach
that referenced
this pull request
May 24, 2022
The RSA key size used by TLS certs for acceptance tests must be at least 2048 to please OpenSSL (which is used by libpq in tests). The previous PR cockroachdb#71134 had improved this for some cases but the chance was hidden in-between other things. This commit makes it clearer what is going on. Release note: None
knz
added a commit
to knz/cockroach
that referenced
this pull request
May 24, 2022
The RSA key size used by TLS certs for acceptance tests must be at least 2048 to please OpenSSL (which is used by libpq in tests). The previous PR cockroachdb#71134 had improved this for some cases but the chance was hidden in-between other things. This commit makes it clearer what is going on. Release note: None
knz
added a commit
to knz/cockroach
that referenced
this pull request
May 24, 2022
The RSA key size used by TLS certs for acceptance tests must be at least 2048 to please OpenSSL (which is used by libpq in tests). The previous PR cockroachdb#71134 had improved this for some cases but the chance was hidden in-between other things. This commit makes it clearer what is going on. Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 24, 2022
81727: acceptance: comply with openssl key size restrictions r=rickystewart a=knz The RSA key size used by TLS certs for acceptance tests must be at least 2048 to please OpenSSL (which is used by libpq in tests). The previous PR #71134 had improved this for some cases but the chance was hidden in-between other things. This commit makes it clearer what is going on. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71102.
Release note (security update): It is not possible any more to use a
node TLS certificate to establish a SQL connection with another
username than
node. This facility had existed as an "escape hatch"so that an operator could use the node cert to perform operations on
behalf of another SQL user. However, this facility is not necessary:
an operator with access to a node cert can log in as
nodedirectlyand create new credentials for another user anyway. By removing
this facility, we tighten the guarantee that the principal in the TLS
client cert always matches the SQL identity.