cluster-ui: derive app name from route parameter in cluster-ui #70999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
xinhaoz
force-pushed
the
fix-app-filtering
branch
from
26621c8 to
a6f99c0
Compare
|
Wait I thought we switched to using query params from route params for app name? |
|
@Azhng We did for the statement details page, this is for the statements page. I think we should really just use a query parameter here too, though. |
xinhaoz
force-pushed
the
fix-app-filtering
branch
from
a6f99c0 to
3dd506d
Compare
|
When I select the demo app, it shows the correct value on the details page, but if I select internal, it's showing some extra query on the details pag |
Fixes: cockroachdb#70998 Release justification: category 2 Previously, we were deriving the selected app name from the query string parameter in for the statements page in the cluster-ui package. The selected app name should be derived from the route parameter for the statements page. Release note (bug fix): the selected app name in the statements page is now derived from the route parameters.
xinhaoz
force-pushed
the
fix-app-filtering
branch
from
3dd506d to
cb31d8d
Compare
maryliag
approved these changes
Oct 1, 2021
complete! 1 of 0 LGTMs obtained
|
bors r=maryliag |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #70998
Release justification: category 2
Previously, we were deriving the selected app name from the
query string parameter in for the statements page in the
cluster-ui package. The selected app name should be derived from
the route parameter for the statements page.
Release note (bug fix): the selected app name in the statements page
is now derived from the route parameters.