Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: prevent statement/transaction page from sending infinite API #70941

Closed
wants to merge 1 commit into from
Closed

ui: prevent statement/transaction page from sending infinite API #70941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/ui/workspaces/cluster-ui/src/statementsPage/statementsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,6 @@ export class StatementsPage extends React.Component<
if (this.state.search && this.state.search !== prevState.search) {
this.props.onSearchComplete(this.filteredStatementsData());
}
this.refreshStatements();
if (!this.props.isTenant) {
this.props.refreshStatementDiagnosticsRequests();
}
};

componentWillUnmount(): void {
Expand Down
2 changes: 1 addition & 1 deletion pkg/ui/workspaces/cluster-ui/src/store/utils/sagaEffects/throttleWithReset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { Action } from "redux";
* Extended version of default `redux-saga/effects/throttle` effect implementation
* with ability to provide actions that trigger reset on delay timer.
*
* For example, `initRequest` sata has to be throttled by specified amount of time and
* For example, `initRequest` saga has to be throttled by specified amount of time and
* also `initRequest` call when specific action dispatched (even if timeout doesn't
* occur).
*
Expand Down
3 changes: 0 additions & 3 deletions pkg/ui/workspaces/cluster-ui/src/transactionsPage/transactionsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,6 @@ export class TransactionsPage extends React.Component<
componentDidMount(): void {
this.refreshData();
}
componentDidUpdate(): void {
this.refreshData();
}

syncHistory = (params: Record<string, string | undefined>) => {
const { history } = this.props;
Expand Down