Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce: show original test case output #70933

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

mgartner
Copy link
Collaborator

The reduce tool now shows the original test case output in verbose
mode if it is not found to be interesting. This makes it easier for a
user to determine why a reproduction is not producing output that
matches the --contains regex.

Release note: None

@mgartner mgartner requested a review from a team September 30, 2021 14:37
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)

Copy link
Contributor

@cucaroach cucaroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner mgartner force-pushed the show-original-output branch from 8e36129 to ea40f04 Compare September 30, 2021 15:59
The `reduce` tool now shows the original test case output in verbose
mode if it is not found to be interesting. This makes it easier for a
user to determine why a reproduction is not producing output that
matches the `--contains` regex.

Release note: None
@mgartner mgartner force-pushed the show-original-output branch from ea40f04 to a42d5c9 Compare September 30, 2021 20:52
@mgartner
Copy link
Collaborator Author

mgartner commented Oct 1, 2021

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 1, 2021

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Oct 1, 2021

Build succeeded:

@craig craig bot merged commit a3ba197 into cockroachdb:master Oct 1, 2021
@mgartner mgartner deleted the show-original-output branch October 1, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants