kv: deflake TestTenantRateLimiter #70723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change (cockroachdb#70328) increased the rate limit and that exposed a fragility in this test. This change restores the test to use the original (small) rate limit. Fixes cockroachdb#70456. Release note: None Release justification: test-only fix.
|
This change is |
ajwerner
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
ajwerner
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
You’ll be interested in the flake.
Reviewable status:
Sigh, indeed. TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (#70328) increased the rate limit and that exposed a
fragility in this test. This change restores the test to use the
original (small) rate limit.
Fixes #70456.
Release note: None
Release justification: test-only fix.