builtins: array builtins handle mismatched tuple types #70606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some cases, we need to propogate the error and return it nicely for the user. See next commit. Release note: None
|
This change is |
|
Drive-by suggestion: maybe it would be simpler to add a panic-catcher specifically when comparing something with arrays? |
otan
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
i'm really hesitant on panic catchers and rather we catch em explicitly.
there have been cases (e.g. spatial) where i wanted an error with Compare but never bothered, might as well begin the pain of ripping off the bandaid...
up to rafi too though. the changes here lgtm :)
|
tftr! bors r=otan |
|
Build failed: |
|
whoops i missed the github ci failure |
Since these builtins take in AnyTuple, the tuple contents aren't type-checked. Instead, we must handle any errors that occur during tuple comparison at execution-time. This matches the PostgresSQL behavior. No release note since this bug was never released anywhere. Release note: None
rafiss
force-pushed
the
fix-array-tuple-compare
branch
from
df40d43 to
dda6518
Compare
|
bors r=otan |
1 similar comment
|
bors r=otan |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #70481
fixes #70480
fixes #70479
fixes #70478
fixes #70477
fixes #70476
The first commit is a refactor to add a new CompareError method
to Datum. It propagates errors instead of panicking.
Since these builtins take in AnyTuple, the tuple contents aren't
type-checked. Instead, we must handle any errors that occur during tuple
comparison at execution-time. This matches the PostgresSQL behavior.
No release note since this bug was never released anywhere.
Release note: None