Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builtins: tighten json*_populate_record to only accept AnyTuple #70550

Closed
wants to merge 1 commit into from

Conversation

otan
Copy link
Contributor

@otan otan commented Sep 22, 2021

types.Any would fail the MustBeDTuple check. As such, change the
typing to only allow AnyTuple.

Resolves #70475

Release note: None

`types.Any` would fail the `MustBeDTuple` check. As such, change the
typing to only allow `AnyTuple`.
Release note: None
@otan otan requested review from jordanlewis and a team September 22, 2021 02:53
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis
Copy link
Member

I think @rafiss #70469 might be doing something similar.

@otan
Copy link
Contributor Author

otan commented Sep 22, 2021

i see!

@otan otan closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/tests: TestRandomSyntaxFunctions failed
3 participants