-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: include ON UPDATE on CREATE TABLE LIKE for INCLUDING DEFAULTS #70472
Conversation
@@ -230,9 +235,10 @@ like_defaults CREATE TABLE public.like_defaults ( | |||
h INT8 NULL, | |||
j JSONB NULL, | |||
k INT8 NULL, | |||
t TIMESTAMPTZ NULL ON UPDATE current_timestamp():::TIMESTAMPTZ, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd be fine keeping this one. i vote we just decide now that INCLUDING DEFAULTS
will also copy ON UPDATE
. but then one thing to check is that a column with both DEFAULT
and ON UPDATE
is copied correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've changed this to be for DEFAULTS because ALL is a bitmask meaning including it on every option. i'm a bad proofreader.
Release note (sql change): CREATE TABLE ... LIKE ... now copies ON UPDATE definitions for INCLUDING DEFAULTS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @otan and @rafiss)
bors r=rafiss |
Build succeeded: |
Resolves #69258
Release note (sql change): CREATE TABLE ... LIKE ... now copies ON
UPDATE definitions for INCLUDING DEFAULTS.