colexecop: harden CloseAndLogOnErr against panics #70467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen a few cases where closing the `Closer`s would lead to a panic which wasn't caught because we're outside of the panic-catcher scope. This commit adds a panic-catcher to `CloseAndLogOnErr` (which is the "root" way of closing things) in order to increase the stability of CRDB in face of edge case bugs. Release note: None
|
This change is |
rytaft
approved these changes
Sep 21, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
|
TFTR! bors r+ |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen a few cases where closing the
Closers would lead toa panic which wasn't caught because we're outside of the panic-catcher
scope. This commit adds a panic-catcher to
CloseAndLogOnErr(which isthe "root" way of closing things) in order to increase the stability of
CRDB in face of edge case bugs.
Addresses: #70000.
Addresses: #70438.
Release note: None