-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.2: logictest: attempt to deflake "disallow full scans" test #70458
Conversation
We've seen a couple of flakes on the testing of "disallow full scans" feature although I couldn't reproduce it manually. In an attempt to deflake the test, this commit increases the corresponding session variable as well as injects the stats manually instead of analyzing the table (to have more tight control over events). Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Although it is a testing only change, I'll hold off until 21.2.0 is out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
@rytaft I'm wondering whether it is ok to merge this now given that we have seen a flake on 21.2 branch and haven't seen new flakes on master? It is testing only change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
TFTR! |
Backport 1/1 commits from #70278 on behalf of @yuzefovich.
/cc @cockroachdb/release
We've seen a couple of flakes on the testing of "disallow full scans"
feature although I couldn't reproduce it manually. In an attempt to
deflake the test, this commit increases the corresponding session
variable as well as injects the stats manually instead of analyzing the
table (to have more tight control over events).
Fixes: #70012.
Release note: None
Release justification: