kvclient/rangefeed: emit checkpoint events #70317
Conversation
|
This change is |
There was a problem hiding this comment.
A test might be nice. I don't think it should be too hard. Namely, write a value and then make sure that you get a checkpoint after you write the value for a timestamp later than the value. You can adjust the closed timestamp interval to make this happen quickly.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @arulajmani)
irfansharif
force-pushed
the
210916.rangefeed-emit-checkpoints
branch
from
72e9869 to
598c6f7
Compare
There was a problem hiding this comment.
Added, PTAL.
Reviewable status:
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
irfansharif
force-pushed
the
210916.rangefeed-emit-checkpoints
branch
from
598c6f7 to
ae23796
Compare
|
bors r+ |
|
bors r- |
|
Canceled. |
irfansharif
force-pushed
the
210916.rangefeed-emit-checkpoints
branch
from
ae23796 to
06134ae
Compare
|
bors single on |
|
bors r+ |
|
Build failed: |
irfansharif
force-pushed
the
210916.rangefeed-emit-checkpoints
branch
from
06134ae to
88a91c6
Compare
Grafted from cockroachdb#69269. This seems like a useful primitive for users of this library. We intend to use it in cockroachdb#69661 and cockroachdb#69614. Release note: None Co-authored-by: irfan sharif <[email protected]>
irfansharif
force-pushed
the
210916.rangefeed-emit-checkpoints
branch
from
88a91c6 to
e14a0a1
Compare
|
bors r+ |
|
Build failed: |
|
I'm not really sure what's up with the bors failure. I assume it's some flake, cause regular github CI is green. Let a brother merge before PTO! bors r+ |
|
Build succeeded: |
Grafted from #69269. This seems like a useful primitive for users of
this library. We intend to use it in #69661 and #69614.
Release note: None