-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.2: roachtest: harden the sqlsmith test #70296
Conversation
Previously, we had some false positives from the `sqlsmith` roachtest filed because of "inbox communication errors" which were actually triggered because of the vectorized panic injection. These errors usually mean that a node died, so we used the errors as a proxy for the crash. This commit adjusts the test to instead ping all nodes in the cluster to see whether they are up or not and not rely on the communication errors. This allows us to ignore the false positives because of the panic injection. Release note: None
38baf7a
to
c10f261
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold off on merging for now.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Yeah, I'll wait until 21.2.0 is out - plus I want to see that this change on master fixes those false positives for good. |
@rytaft I think this change does fix the false positive issue, so I'm thinking whether we should go ahead and merge this given it is a testing only change to reduce the noise? |
Yep, go ahead and merge. Thanks! |
Backport 1/1 commits from #70280 on behalf of @yuzefovich.
/cc @cockroachdb/release
Previously, we had some false positives from the
sqlsmith
roachtestfiled because of "inbox communication errors" which were actually
triggered because of the vectorized panic injection. These errors
usually mean that a node died, so we used the errors as a proxy for the
crash. This commit adjusts the test to instead ping all nodes in the
cluster to see whether they are up or not and not rely on the
communication errors. This allows us to ignore the false positives
because of the panic injection.
Fixes: #66174.
Release note: None
Release justification: