sql: fix JSON deserialization for sql stats lastExecAt field #70281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
xinhaoz
approved these changes
Sep 15, 2021
Azhng
force-pushed
the
sqlstats-last-exec
branch
2 times, most recently
from
4e0e5c8 to
75d806b
Compare
maryliag
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @Azhng)
Previsouly, lastExecAt field for roachpb.CollectedStatementStatistics was not properly updated. This caused the status API to return empty data for that field. This commit fixes the deserialization and extended the randomize testing framework to also test time.Time type. Partially Resolves cockroachdb#69675 Release Justification: Bug fixes and low-risk updates to new functionality Release note (bug fix): Last Execution Timestamp is now properly updating.
Azhng
force-pushed
the
sqlstats-last-exec
branch
from
75d806b to
4d0c386
Compare
|
TFTR! bors r=maryliag,xinhaoz |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previsouly, lastExecAt field for roachpb.CollectedStatementStatistics
was not properly updated. This caused the status API to return
empty data for that field.
This commit fixes the deserialization and extended the randomize
testing framework to also test time.Time type.
Partially Resolves #69675
Release Justification: Bug fixes and low-risk updates to new
functionality
Release note (bug fix): Last Execution Timestamp is now properly
updating.