opt: autocommit when RETURNING expressions are leak-proof #70200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, mutations under a Project could only be auto-committed when the Project had only passthrough columns and no projection expressions. Now, a mutation under a Project can auto-commit if all the projections are leak-proof. Release note (performance improvement): Mutation statements with a RETURNING clause that are not inside an explicit transaction are faster in some cases.
|
This change is |
RaduBerinde
approved these changes
Sep 14, 2021
complete! 1 of 0 LGTMs obtained
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, mutations under a Project could only be auto-committed when
the Project had only passthrough columns and no projection expressions.
Now, a mutation under a Project can auto-commit if all the projections
are leak-proof.
Release note (performance improvement): Mutation statements with a
RETURNING clause that are not inside an explicit transaction are faster
in some cases.