changefeedccl: check that rangefeeds are enabled earlier #70130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
requested review from
a team and
samiskin
and removed request for
a team
stevendanna
commented
Sep 13, 2021
| "CHANGEFEED", | ||
| ); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I'm moving this down into the returned PlanHookRowFn based on this discussion: https://cockroachlabs.slack.com/archives/C9TGBJB44/p1631200940138700
samiskin
approved these changes
Sep 13, 2021
miretskiy
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)
Pushing this check earlier means that for core changefeeds, the check happens before the backfill. Previously an error would only be seen after the backfill when we attempted to start the rangefeed, which some users found confusing. Release note: None
stevendanna
force-pushed
the
ssd/rangefeed-check-early
branch
from
55d9096 to
e372d9e
Compare
|
bors r=miretskiy |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this check earlier means that for core changefeeds, the check
happens before the backfill. Previously an error would only be seen
after the backfill when we attempted to start the rangefeed, which
some users found confusing.
Release note: None